Skip to content

Conversation

@jfreire-unity
Copy link
Collaborator

Description

6.2 introduces some API changes and obsoleted some APIs used in Touch Samples. The file publish.sh needed to be updated to accept scripting updates automatically. Similar to what one would do when opening the Editor, to avoid having console errors.
image

Testing status & QA

Local test on macOS. The script only works out of the box in a Unix environment.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

If CI passes it should be enough for approval.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

Copy link
Collaborator

@ritamerkl ritamerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment on lines +12 to +13
rm -rf ${Sample}Packages
rm -rf ${Sample}ProjectSettings
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to make the script avoid showing "warnings".
Packages is a folder that contains more folders so there was a warning and just using rm -r wasn't enough.

@jfreire-unity
Copy link
Collaborator Author

jfreire-unity commented Feb 6, 2025

All checks have passed in Yamato but for some reason GitHub didn't get that information after 2h. I'll force squash this PR.

@jfreire-unity jfreire-unity merged commit b5e3ca1 into develop Feb 6, 2025
91 of 94 checks passed
@jfreire-unity jfreire-unity deleted the fix-6.2-publish-samples-script branch February 6, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants